Prevents VPNSettings from reporting fake changes #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
commented
Dec 22, 2023
| @@ -121,6 +121,11 @@ final class NetworkProtectionAppEvents { | |||
| versionStore.lastVersionRun = currentVersion | |||
| } | |||
|
|
|||
| #if DEBUG | |||
There was a problem hiding this comment.
This change is to make sure we reload the login item always when debugging.
diegoreymendez
changed the title
quanganhdo
approved these changes
Dec 22, 2023
| @@ -121,6 +121,11 @@ final class NetworkProtectionAppEvents { | |||
| versionStore.lastVersionRun = currentVersion | |||
| } | |||
|
|
|||
| #if DEBUG | |||
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Dec 22, 2023
Task/Issue URL: https://app.asana.com/0/0/1206212872939261/f iOS PR: duckduckgo/iOS#2288 macOS PR: duckduckgo/macos-browser#2004 What kind of version bump will this require?: Patch ## Description Makes some changes to `VPNSettings` so that it won't publish fake settings updates.
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Dec 22, 2023
Task/Issue URL: https://app.asana.com/0/0/1206212872939261/f macOS PR: duckduckgo/macos-browser#2004 BSK PR: duckduckgo/BrowserServicesKit#614 ## Description Makes some changes to VPNSettings so that it won't publish fake settings updates.
samsymons
added a commit
that referenced
this pull request
Dec 24, 2023
# By Diego Rey Mendez (4) and others # Via Fernando Bunn (2) and GitHub (1) * main: Adds option + click support for our VPN menu to show some useful debu… (#2007) Update latency & tunnel failure monitor implementation (#2005) Prevents VPNSettings from reporting fake changes (#2004) Updates the copy for the VPN status bar item context menu (#2003) Implement subscription purchase (#1906) DBP: Add m_mac prefix to Pixels (#1952) Bump version to 1.69.0 (96) Update embedded files Update Link Tracking Protection to preserve headers (#1965) VPN menus improvements (#1979) Data Import ux redo (#1754) Fix: "SwiftLintPlugin" must be enabled before it can be used (#1987) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/NavigationBar/View/NavigationBarViewController.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206212872939261/f
iOS PR: duckduckgo/iOS#2288
BSK PR: duckduckgo/BrowserServicesKit#614
Description
Makes some changes to VPNSettings so that it won't publish fake settings updates.
Also changes main App's startup behaviour slightly so that the VPN menu app will relaunch every time the main app launches (for debug builds only). This is to make testing easier.
Testing
launchctl remove com.duckduckgo.macos.vpn.debugfrom your terminal to ensure the VPN menu app isn't running.Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation